Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update formatting for TOC #1186

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Update formatting for TOC #1186

merged 9 commits into from
Mar 8, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Mar 6, 2024 •
edited
Loading

Closes #1010

  • Fix formatting for PR - Update heading to reflect formatting for options, subcommands, methods.

@joaniefromtheblock joaniefromtheblock requested review from a team as code owners March 6, 2024 00:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Preview published: update-toc

@MetaMask MetaMask deleted a comment from github-actions bot Mar 6, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Mar 6, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Mar 6, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Mar 6, 2024
@joaniefromtheblock
Copy link
Contributor Author

joaniefromtheblock commented Mar 6, 2024 •
edited
Loading

This is what it looks like in my local build ...
image

Unfortunately, the build preview does not look the same

@alexandratran alexandratran self-assigned this Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Preview published: update-toc

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Preview published: update-toc

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Preview published: update-toc

@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner March 8, 2024 00:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Preview published: update-toc

alexandratran
alexandratran approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updated the correct variable that was previously set to a single font size
  • Added missing code formatting throughout the docs (including non-reference pages)
  • Adjusted some heading levels
  • Removed the border from the code format style

@joaniefromtheblock
Copy link
Contributor Author

You fixed it! Thanks @alexandratran

@joaniefromtheblock joaniefromtheblock merged commit 7bfc13f into main Mar 8, 2024
8 checks passed
@joaniefromtheblock joaniefromtheblock deleted the update-toc branch March 8, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

@subhamkumarr subhamkumarr subhamkumarr approved these changes

Assignees

@alexandratran alexandratran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code format in headings and TOCs
3 participants
@joaniefromtheblock @alexandratran @subhamkumarr